Support std::list iteration & modification#2370
Open
ax3l wants to merge 7 commits intoEnzymeAD:mainfrom
Open
Conversation
Add support for inserting elements in `std::list`. Close EnzymeAD#2369
wsmoses
approved these changes
Jul 2, 2025
ax3l
commented
Jul 2, 2025
ax3l
force-pushed
the
topic-std-list-insertion
branch
3 times, most recently
from
48f2dfa to
fc8d65e
Compare
ax3l
commented
Jul 2, 2025
ax3l
force-pushed
the
topic-std-list-insertion
branch
from
fc8d65e to
cd6640d
Compare
Contributor
Author
|
@wsmoses there seem to be issues with iterators for the reverse pass ( Should iterators work by default, especially since they just work on references and |
Member
|
it should work perfectly fine, sorry can you point me to the small snippet which fails? |
ax3l
force-pushed
the
topic-std-list-insertion
branch
from
81908f0 to
9b1793a
Compare
ax3l
force-pushed
the
topic-std-list-insertion
branch
from
7941ef5 to
c14abdc
Compare
Currently fails.
ax3l
force-pushed
the
topic-std-list-insertion
branch
from
ba5111c to
e063006
Compare
Contributor
Author
|
Skipping I added a test I think we need a special treatment for |
ax3l
force-pushed
the
topic-std-list-insertion
branch
5 times, most recently
from
f092368 to
a74da5d
Compare
ax3l
force-pushed
the
topic-std-list-insertion
branch
from
a74da5d to
32e6481
Compare
ax3l
changed the title
std::list iterationstd::list iteration & modification
ax3l
commented
Jul 9, 2025
ax3l
commented
Jul 9, 2025
ax3l
commented
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for iterating & modifying elements in
std::list. Close #2369